Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement lingo init for Zephyr and Native #10

Merged
merged 12 commits into from
May 3, 2023
Merged

Implement lingo init for Zephyr and Native #10

merged 12 commits into from
May 3, 2023

Conversation

erlingrj
Copy link
Collaborator

This PR implements the lingo init command for the Zephyr and the default (Native) platform. I went with the following command structure:

lingo init --platform/-p zephyr --language/-l c

We use git to clone the lf-west-template down from Github and populate a project directory.

tanneberger
tanneberger approved these changes Apr 30, 2023
View reviewed changes
Copy link
Member

@tanneberger tanneberger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. I guess u tested the init does the building work with the normal lfc ? And maybe to the quick cargo clippy :D

@erlingrj
Copy link
Collaborator Author

Did you understand the clippy output? The lingo build command is not successful because it tries to invoke: lfc --output (see FIXME in lfc.rs). What is the intention of this build step?

@tanneberger
Copy link
Member

I was just some problem with clap 3 I updated to clap 4 and the issue resolved itself.

@tanneberger tanneberger added the enhancement New feature or request label May 1, 2023
@tanneberger
Copy link
Member

This panic there is that the CodeGenerator expects an absolute path to lfc and if the path doesn't exists we can only panic.

@tanneberger
Copy link
Member

But yeah regarding this fixme I would leave it for know and replaced with a search in $PATH with the help of this crate: https://crates.io/crates/which

@erlingrj
Copy link
Collaborator Author

erlingrj commented May 2, 2023 •
edited
Loading

I think in order to merge this we should:

  • Implement the blacklist-based copying of the west-template
  • Make sure TargetLangauge is default C with platform Zephyr.

@erlingrj erlingrj requested a review from tanneberger May 2, 2023 20:07
@tanneberger tanneberger merged commit 01983ed into main May 3, 2023
@tanneberger tanneberger deleted the init-zephyr branch July 2, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanneberger tanneberger Awaiting requested review from tanneberger

Assignees

@erlingrj erlingrj

@tanneberger tanneberger

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erlingrj @tanneberger